Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[quote] - auto-instrumentation produces more span than expected since #644 #659

Closed
puckpuck opened this issue Dec 24, 2022 · 1 comment · Fixed by #702
Closed

[quote] - auto-instrumentation produces more span than expected since #644 #659

puckpuck opened this issue Dec 24, 2022 · 1 comment · Fixed by #702
Labels
bug Something isn't working

Comments

@puckpuck
Copy link
Contributor

Bug Report

The quoteservice now produces 14 spans on each request. This used to be 2 spans before #644 was merged. Fixing this may require updates to the PHP SDK itself.

Screenshot of a trace snippet with the quoteserivce involved showing 14 spans for a GetQuote request
Screen Shot 2022-12-24 at 12 40 24 AM

/cc @brettmc
@puckpuck puckpuck added the bug Something isn't working label Dec 24, 2022
@brettmc
Copy link
Contributor

brettmc commented Jan 16, 2023

In progress, I've got it down to 3 spans which feels like a sane amount (remembering that it's being instrumented by a generalized auto-instrumentation for the framework that quoteservice uses, not specialized for the demo):

Screenshot from 2023-01-10 16-15-38

@cartersocha cartersocha mentioned this issue Jan 20, 2023
Merged
2 tasks
@brettmc brettmc mentioned this issue Feb 15, 2023
Open
@svrnm svrnm mentioned this issue Feb 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reduce quoteservice spans brettmc/opentelemetry-demo
2 participants
@puckpuck @brettmc