Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component owners for adservice Java app #519

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

trask
Copy link
Member

@trask trask commented Oct 22, 2022

This would allow @jack-berg @mateuszrzeszutek and me to get pinged on any PRs that touch the Java app so we can help review. @dyladan's component-owners github action is being used in a few other otel repos already: https://github.com/search?q=org%3Aopen-telemetry+dyladan%2Fcomponent-owners&type=code

@trask trask requested a review from a team October 22, 2022 18:17
@cartersocha
Copy link
Contributor

Thanks for adding this @trask! This could be a good model to replicate for the other services depending on sig interest

Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to get SIG maintainers to help with ownership of individual services.

@cartersocha cartersocha merged commit 8ab9828 into open-telemetry:main Oct 23, 2022
@trask trask deleted the add-component-owners branch October 23, 2022 02:19
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants