-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Resource Detectors to frontend service #648
Add Resource Detectors to frontend service #648
Conversation
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svrnm this is really cool!
Thanks for this PR.
We have something similar in Rust, but not with that many resourceDetectors.
Happy to help & that you like it:-)
There are implementations of container resource detection & cloud resource detection across many languages, so they can be used as a template for rust, since the mechanics are always the same (e.g. for container.id you need to read it from the right files, and for the cloud ones there are APIs). |
@puckpuck / @julianocosta89 I feel like we should document the resource enrichment somewhere? Maybe a dedicated file to keep things simple or add to the attributes file |
Thanks for the addition @svrnm! This looks great 🚀 |
Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com>
@cartersocha is something to discuss in the SIG meeting in the new year, but I think we can put Resource detection in the feature/metric matrix tables. We should also document how it is accomplished in each service doc, similar to how we show other instrumentation features. |
* Add Resource Detectors to frontend service Signed-off-by: svrnm <neumanns@cisco.com> * Update documentation, fixing style Signed-off-by: svrnm <neumanns@cisco.com> * Add PR no and link to CHANGELOG Signed-off-by: svrnm <neumanns@cisco.com> * Update src/frontend/package.json Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com> Signed-off-by: svrnm <neumanns@cisco.com> Co-authored-by: Juliano Costa <julianocosta89@outlook.com> Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com> Co-authored-by: Pierre Tessier <pierre@pierretessier.com>
Changes
This will add resource detectors to the frontend service, to create richer data for the backend, e.g.:
Similar could be done for other languages/services, I just wanted to get started with Node.JS where I know how to do it :-)
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additions