Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanmetrics dashboard premiere #787

Merged

Conversation

devrimdemiroz
Copy link
Contributor

@devrimdemiroz devrimdemiroz commented Mar 9, 2023

Changes

Sample spanmetrics dashboard showing service and operational level throughputs and latencies.

Light-spanmetrics_dashboard2

DarkBlues-spanmetrics_dashboard

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@devrimdemiroz devrimdemiroz requested a review from a team March 9, 2023 23:00
@puckpuck puckpuck added helm-update-required Requires an update to the Helm chart when released v1.4 labels Mar 10, 2023
Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic!
Thank you for this.

@fatsheep9146
Copy link
Contributor

awesome!

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I loved it! 🤩

Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

@julianocosta89 julianocosta89 merged commit 8364c0f into open-telemetry:main Mar 10, 2023
@devrimdemiroz
Copy link
Contributor Author

Thanks for accepting it. With my pleasure! 🥳

Very soon, we will need to change the spanmetrics naming, namespace, and metric structure ... a breaking change is incoming.

styblope pushed a commit to instana/opentelemetry-demo that referenced this pull request Mar 12, 2023
* spanmetrics dashboard premiere

* cleaned up unnecessary datasources mistake

* pr open-telemetry#787 added to changelog

* markdown check fix

---------

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
@devrimdemiroz devrimdemiroz deleted the feature/spanmetrics_dashboard branch March 12, 2023 23:43
mat-rumian pushed a commit to SumoLogic/opentelemetry-demo that referenced this pull request Mar 20, 2023
* spanmetrics dashboard premiere

* cleaned up unnecessary datasources mistake

* pr open-telemetry#787 added to changelog

* markdown check fix

---------

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
juliangiuca pushed a commit to juliangiuca/opentelemetry-demo that referenced this pull request Apr 12, 2023
* spanmetrics dashboard premiere

* cleaned up unnecessary datasources mistake

* pr open-telemetry#787 added to changelog

* markdown check fix

---------

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* spanmetrics dashboard premiere

* cleaned up unnecessary datasources mistake

* pr open-telemetry#787 added to changelog

* markdown check fix

---------

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants