Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecordException = true behavior in Http instrumentation #2014

Closed
vishweshbankwar opened this issue Oct 17, 2022 · 0 comments
Closed

RecordException = true behavior in Http instrumentation #2014

vishweshbankwar opened this issue Oct 17, 2022 · 0 comments
Labels
bug Something isn't working comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http

Comments

@vishweshbankwar
Copy link
Member

Unit tests validating the behavior (i.e. whether the output span will contain the exception event) was added in open-telemetry/opentelemetry-dotnet#3761. Opening this issue to summarize the details and discuss any improvements that may be needed towards making the experience consistent. Following table summarizes the output for each method that was added in unit test.

Class Name Method Name Response code Exception SpanEvent
HttpClient GetAsync Error response code No
HttpClient GetAsync Network error Yes
HttpClient GetStringAsync Network error Yes
HttpClient GetStringAsync Error response code No
WebRequest GetResponseAsync Error response code Yes
WebRequest GetResponseAsync Network error Yes
@vishweshbankwar vishweshbankwar added the bug Something isn't working label Oct 17, 2022
@vishweshbankwar vishweshbankwar transferred this issue from open-telemetry/opentelemetry-dotnet Aug 21, 2024
@vishweshbankwar vishweshbankwar added the comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http
Projects
None yet
Development

No branches or pull requests

2 participants