-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RabbitMQ] bytecode instrumentation for versions 6.*.* - initial #3533
Merged
zacharycmontoya
merged 15 commits into
open-telemetry:main
from
lachmatt:rabbitmq6-bytecode-instrumentation
Aug 6, 2024
Merged
[RabbitMQ] bytecode instrumentation for versions 6.*.* - initial #3533
zacharycmontoya
merged 15 commits into
open-telemetry:main
from
lachmatt:rabbitmq6-bytecode-instrumentation
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
reviewed
Jul 24, 2024
src/OpenTelemetry.AutoInstrumentation/Configurations/TracerInstrumentation.cs
Outdated
Show resolved
Hide resolved
...rumentation/Instrumentations/RabbitMq6/Integrations/AsyncEventingBasicConsumerIntegration.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.AutoInstrumentation/Instrumentations/MessagingAttributes.cs
Show resolved
Hide resolved
Kielek
approved these changes
Jul 31, 2024
nrcventura
approved these changes
Jul 31, 2024
zacharycmontoya
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM, thanks for contributing this instrumentation!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Towards: #3392
What
Bytecode instrumentation for RabbitMQ client versions >=6.0.0 &< 7.0.0
Instrumentation creates following spans:
receive
whenBasicGet
is used to retrieve messages (polling)process
whenAsyncEventingBasicConsumer
andEventingBasicConsumer
are usedpublish
when messages are published usingBasicPublish
Span names, attributes set and their values are based on recently added instrumentation in RabbitMQ client (to be released with version 7.0.0) and messaging semantic conventions.
Targeted types are similar to types targeted by datadog's RabbitMq client instrumentation. @zacharycmontoya please review and approve if you accept it from datadog's side.
Note:
Followup PRs required to address:
process
spansDerived
andInterface
should be created for consumer typesTests
Included in PR.
Checklist
CHANGELOG.md
is updated.