From 6570696fb3ccad66ae33d9d8329697ccc7370ee0 Mon Sep 17 00:00:00 2001 From: Utkarsh Umesan Pillai <66651184+utpilla@users.noreply.github.com> Date: Mon, 28 Aug 2023 13:47:14 -0700 Subject: [PATCH] Update default value for simple exemplar reservoir size (#4803) --- src/OpenTelemetry/CHANGELOG.md | 3 +++ src/OpenTelemetry/Metrics/MetricPoint.cs | 3 +-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/OpenTelemetry/CHANGELOG.md b/src/OpenTelemetry/CHANGELOG.md index 97376f4c7fb..63cbb5b79f8 100644 --- a/src/OpenTelemetry/CHANGELOG.md +++ b/src/OpenTelemetry/CHANGELOG.md @@ -5,6 +5,9 @@ * Increased the character limit of the Meter instrument name from 63 to 255. ([#4774](https://github.com/open-telemetry/opentelemetry-dotnet/issues/4774)) +* Update default size for `SimpleExemplarReservoir` to `1`. + ([#4803](https://github.com/open-telemetry/opentelemetry-dotnet/issues/4803)) + ## 1.6.0-rc.1 Released 2023-Aug-21 diff --git a/src/OpenTelemetry/Metrics/MetricPoint.cs b/src/OpenTelemetry/Metrics/MetricPoint.cs index f4fc5c5a265..110d59e8c0a 100644 --- a/src/OpenTelemetry/Metrics/MetricPoint.cs +++ b/src/OpenTelemetry/Metrics/MetricPoint.cs @@ -26,8 +26,7 @@ namespace OpenTelemetry.Metrics; /// public struct MetricPoint { - // TODO: Ask spec to define a default value for this. - private const int DefaultSimpleReservoirPoolSize = 10; + private const int DefaultSimpleReservoirPoolSize = 1; private readonly AggregatorStore aggregatorStore;