Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AddTag with SetTag #1226

Closed
reyang opened this issue Sep 3, 2020 · 3 comments · Fixed by #1227
Closed

Replace AddTag with SetTag #1226

reyang opened this issue Sep 3, 2020 · 3 comments · Fixed by #1227
Assignees
@eddynaka
Labels
bug Something isn't working

Comments

@reyang
Copy link
Member

reyang commented Sep 3, 2020 •
edited
Loading

SetTag seems to be the way to go and we probably want to replace all AddTag calls in this repo?

https://github.com/open-telemetry/opentelemetry-dotnet/search?q=AddTag&unscoped_q=AddTag
@reyang reyang added the bug Something isn't working label Sep 3, 2020
@reyang reyang mentioned this issue Sep 3, 2020
Closed
@eddynaka
Copy link
Contributor

eddynaka commented Sep 3, 2020

@reyang , are u going to replace? or should I?

@reyang
Copy link
Member Author

reyang commented Sep 3, 2020

Feel free to take it.

@cijothomas
Copy link
Member

@eddynaka Also check if we are retrieving Activity.Tags. It should be Activity.TagObjects

@eddynaka eddynaka mentioned this issue Sep 3, 2020
Merged
3 tasks
@ZRich97 ZRich97 mentioned this issue Nov 28, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddynaka eddynaka

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@cijothomas @eddynaka @reyang