Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParentBasedSampler should not make decision based on Links #1846

Closed
cijothomas opened this issue Feb 24, 2021 · 1 comment · Fixed by #1851
Closed

ParentBasedSampler should not make decision based on Links #1846

cijothomas opened this issue Feb 24, 2021 · 1 comment · Fixed by #1851
Labels
bug Something isn't working

Comments

@cijothomas
Copy link
Member

The current ParentBasedSampler considers parent and linked activities for making sampling decision.
https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry/Trace/ParentBasedSampler.cs#L56-L69

This is not conforming to the spec for ParentBasedSampler, and must be treated as a bug. The spec does allow Samplers to access Links and make decisions based on that, but ParentBasedSampler is not expected to do that.

Related PR: #1727
@cijothomas cijothomas added the bug Something isn't working label Feb 24, 2021
@cijothomas
Copy link
Member Author

@mbakalov is doing this.
Thank you!

@mbakalov mbakalov mentioned this issue Feb 25, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ParentBasedSampler should not explicitly consider Links mbakalov/opentelemetry-dotnet
1 participant
@cijothomas