OTLP: Span.Status is not populated from Activity.Status

[zakimaksyutov]

Bug Report

List of NuGet packages and
version that you are using (e.g. OpenTelemetry 1.0.2):

<PackageReference Include="OpenTelemetry.Exporter.Console" Version="1.2.0-alpha1" />
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.2.0-beta1" />

Runtime version (e.g. net461, net48, netcoreapp3.1, net5.0 etc. You can
find this information from the *.csproj file):

net5.0

Symptom

Activity.SetStatus is not propagated into Span.Status.

using (var activity = MyActivitySource.StartActivity("MyActivity", ActivityKind.Producer))
{
  activity?.SetStatus(ActivityStatusCode.Error);
}

What is the expected behavior?

Span.Status contains information from Activity (success/failure + [optional] message)

What is the actual behavior?

Span.Status is always null

[alanwest]

Confirmed this is an issue.

The reason is that Activity.SetStatus has been introduced into System.DiagnosticSource 6.0 and the OpenTelemetry API takes a dependency on this package.

Prior to 6.0, .NET did not support SetStatus, so the OpenTelemetry .NET project supplies an extension method. See:

opentelemetry-dotnet/src/OpenTelemetry.Api/Trace/ActivityExtensions.cs

Lines 34 to 45 in fe24768

	/// <summary>
	/// Sets the status of activity execution.
	/// Activity class in .NET does not support 'Status'.
	/// This extension provides a workaround to store Status as special tags with key name of otel.status_code and otel.status_description.
	/// Read more about SetStatus here https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#set-status.
	/// </summary>
	/// <param name="activity">Activity instance.</param>
	/// <param name="status">Activity execution status.</param>
	[MethodImpl(MethodImplOptions.AggressiveInlining)]
	[System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "ActivityProcessor is hot path")]
	public static void SetStatus(this Activity activity, Status status)
	{

We need to support the newly introduced official SetStatus method.

In case you need an immediate workaround, you can use the extension method by declaring using OpenTelemetry.Trace.

[cijothomas]

Related to this: #2064

[cijothomas]

Closing as duplicate, as this is tracked in #2569