Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid allocation in AggregatorStore for MetricPoint lookup #2838

Closed
utpilla opened this issue Feb 1, 2022 · 0 comments · Fixed by #2865
Closed

Avoid allocation in AggregatorStore for MetricPoint lookup #2838

utpilla opened this issue Feb 1, 2022 · 0 comments · Fixed by #2865
Labels
enhancement New feature or request metrics Metrics signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package

Comments

@utpilla
Copy link
Contributor

utpilla commented Feb 1, 2022

Currently, AggregatorStore avoids allocation when looking up MetricPoint index. After #2805 is merged, we would be allocating if the user provides a combination of tags that is not present in the dictionary.

#2805 (comment)
@utpilla utpilla added the enhancement New feature or request label Feb 1, 2022
@cijothomas cijothomas added pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package metrics Metrics signal related labels Feb 1, 2022
This was referenced Feb 2, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request metrics Metrics signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Milestone
No milestone
2 participants
@cijothomas @utpilla