Disallow LogRecord options to be updated after initialization.

[Yun-Ting]

Bug Report

Currently, the SDK allows LogRecord options to be changed after the object was being built by the LoggerFactory.
This could introduce unnecessary complexity toward different states (before/after options got updated) and making it harder to maintain.

Discussion: #2891 (comment)

What is the expected behavior?
Remove existing test code on changing the LogRecord options after the object was being built by the LoggerFactory in LogRecordTest.cs and OtlpLogExporterTests.cs`.

(To be discussed)
Explicitly disallow LogRecord options to be tweaked after instantiation.

[cijothomas]

I would treat it as a bug that current LoggingProvider respected changes after building the factory. We need to "snapshot" the options, and not respect changes done after that. Only exception is adding processors, which is a documented/supported feature for traces, and we share same pipeline for logs as well, so need to keep it that for consistency.

[TimothyMothra]

I'm interested in working on this.

I think this is an easy fix.
Can add this to the OpenTelemetryLoggerOptions class
internal OpenTelemetryLoggerOptions DeepCopy() => (OpenTelemetryLoggerOptions)this.MemberwiseClone();

and call this method in the OpenTelemetryLoggerProvider ctor
this.Options = options.DeepCopy();

This will clone all the boolean properties.
This won't clone any of reference-type fields, but these are only accessed once in the ctor and never again.

opentelemetry-dotnet/src/OpenTelemetry/Logs/OpenTelemetryLoggerProvider.cs

Lines 47 to 58 in 4d6c05c

	internal OpenTelemetryLoggerProvider(OpenTelemetryLoggerOptions options)
	{
	Guard.ThrowIfNull(options);
	this.Options = options;
	this.Resource = options.ResourceBuilder.Build();
	foreach (var processor in options.Processors)
	{
	this.AddProcessor(processor);
	}
	}

[cijothomas]

I would treat it as a bug that current LoggingProvider respected changes after building the factory. We need to "snapshot" the options, and not respect changes done after that. Only exception is adding processors, which is a documented/supported feature for traces, and we share same pipeline for logs as well, so need to keep it that for consistency.

^Correction to above. As of today, there is no ability to add processors after building the factory. This is different from tracing.