[Logs] ObjectDisposedException when using ParseStateValues

[glucaci]

When using ParseStateValues option for logging the app crash

Unhandled exception. System.ObjectDisposedException: IFeatureCollection has been disposed.
Object name: 'Collection'.

• TargetFramework: net6.0
• "OpenTelemetry.Exporter.OpenTelemetryProtocol.Logs" Version="1.0.0-rc9"
• "OpenTelemetry.Instrumentation.AspNetCore" Version="1.0.0-rc9"

[cijothomas]

Quick note on root cause:

1. OTel is storing the state from ILogger.Log into LogRecord.
2. When iterating over "state", if the state is tied to context, which is already disposed, we'll get this exception.
3. In this particular case, the HttpRequest is powering the state as shown here: https://github.com/dotnet/aspnetcore/blob/c85baf8db0c72ae8e68643029d514b2e737c9fae/src/Hosting/Hosting/src/Internal/HostingRequestStartingLog.cs#L23-L35
4. When used in BatchProcessor, where Request is already gone, this throws.

@CodeBlanch fixed the issue for Scopes, by copying the Scope, before we go out of the Logging scope. We need to do something similar.

Irrespective of the above, OTLP LogExporter should not throw and cause app crash - this is a quick fix and can be addressed in coming release. The fix for the above issue (with accessing state after the "state" is disposed) need more time.

[glucaci]

Thanks for update.

When will be a new release? A new RC will be nice, because are already 2 crashing bugs for Logs.

[cijothomas]

Waiting for the 3rd crash 😆 ...
Not really - There will be a release in ~1 week, as soon as some OTLP Configuration (metrics related) changes are merged. And of course the crash bug needs to be fixed as well.

(Release process is still manual, so want to do one when there is a reasonable amount of payload.)

[cijothomas]

The fix for the above issue (with accessing state after the "state" is disposed) need more time.

The fix for the above issue (with accessing state after the "state" is disposed) need more time.

^ @CodeBlanch agreed to look at addressing this issue.