Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OTEL_METRIC_EXPORT_INTERVAL and OTEL_METRIC_EXPORT_TIMEOUT #3417

Closed
pellared opened this issue Jun 29, 2022 · 0 comments · Fixed by #3424
Closed

Support OTEL_METRIC_EXPORT_INTERVAL and OTEL_METRIC_EXPORT_TIMEOUT #3417

pellared opened this issue Jun 29, 2022 · 0 comments · Fixed by #3424
Assignees
Labels
enhancement New feature or request metrics Metrics signal related pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package

Comments

@pellared
Copy link
Member

Feature Request

Support for OTEL_METRIC_EXPORT_INTERVAL and OTEL_METRIC_EXPORT_TIMEOUT environmental variables.

Reference: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md#periodic-exporting-metricreader

Is your feature request related to a problem?

See: open-telemetry/opentelemetry-dotnet-instrumentation#900

Describe the solution you'd like:

OTEL_METRIC_EXPORT_INTERVAL and OTEL_METRIC_EXPORT_TIMEOUT can be used to set PeriodicExportingMetricReaderOptions values if these were not programmatically set to non-default values.

Describe alternatives you've considered.

Implement it only on the https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation.

Additional Context

It can be handy for the users and it will also be reused in https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation

It should be easy to implement it here: https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry/Internal/PeriodicExportingMetricReaderHelper.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request metrics Metrics signal related pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant