Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Improve tests quality #3425

Closed
TimothyMothra opened this issue Jul 1, 2022 · 4 comments
Closed

[Proposal] Improve tests quality #3425

TimothyMothra opened this issue Jul 1, 2022 · 4 comments
Labels
enhancement New feature or request Stale Issues and pull requests which have been flagged for closing due to inactivity

Comments

@TimothyMothra
Copy link
Contributor

TimothyMothra commented Jul 1, 2022

I want to improve current tests to improve both reliability and coverage.
The goal is to empower developers to make necessary changes and have high confidence that use cases aren't being broken.

To accomplish this, I'm proposing making investments in the following areas:

  1. Code Coverage as measured by CodeCov.
    As of 2022-07-01, There are 16 libraries. Overall code coverage is 86.21%. 11 libraries have less than 90% coverage. 2 are less than 80%.
    See also Improve Code Coverage #3353
    • 1a. Most Important libraries (OpenTelemetry, OTLP Exporter).
      These libraries are deemed important because they are depended on by several other libraries or is the core to the overall OpenTelemetry project.
      Goal is to get these closer to 100% coverage, regardless of the triviality of those tests.
      TODO: Need to confirm this list.
    • 1b. Everything else.
      Goal is to get these tests to 90%, prioritizing meaningful tests.
    • 1c. Integration Tests.
      Not certain if these are currently reported as part of overall code coverage.
      These should be used where appropriate to avoid excessive mocking.
  2. Reliability
    Flaky tests impact both devs and reviewers when the CI can't be trusted.
    To accomplish this, Flaky tests need to be reported/collected in an issue(s) for further review.
    See also Test stability - PrometheusExporterHttpServerTests.PrometheusExporterHttpServerIntegration #3292, Test stability - Instrumentation.AspNetCore.Tests.IncomingRequestsCollectionsIsAccordingToTheSpecTests opentelemetry-dotnet-contrib#1752
@TimothyMothra TimothyMothra added the enhancement New feature or request label Jul 1, 2022
@TimothyMothra
Copy link
Contributor Author

Discussed in Community Meeting (2022-07-05).
No objections. :)

@reyang
Copy link
Member

reyang commented Jan 26, 2024

What's the update?

Copy link
Contributor

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Nov 22, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this issue is still a concern.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Development

No branches or pull requests

2 participants