-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for OTEL_TRACES_SAMPLER and OTEL_TRACES_SAMPLER_ARG #3601
Comments
@open-telemetry/dotnet-maintainers , do you have some time to provide this functionality on the Sdk side? |
Hello :), I was wondering what is the status of this PR #3635, is there any reason why it was not merged ? |
@anneelisabethlelievre, there is another attempt to bring it. Please check #3833, @CodeBlanch, what is ypur plan on this PR? |
Is there a workaround to even set these properly for an app? Currently we rolling this out library out for some production applications. A bit worried that there are no options to throttle tracing for high traffic apps. Don't need to trace everything all the time. |
|
Feature Request
Needed by AutoInstrumentation: open-telemetry/opentelemetry-dotnet-instrumentation#1091
Add support for
OTEL_TRACES_SAMPLER
andOTEL_TRACES_SAMPLER_ARG
per specification:https://github.com/open-telemetry/opentelemetry-specification/blob/6ce62202e5407518e19c56c445c13682ef51a51d/specification/sdk-environment-variables.md?plain=1#L46
Describe the solution you'd like
Add possibility to configure standard samplers based on env. variabla in SDK repository.
Describe alternatives you've considered
Implement it on Automatic Instrumentation side. It can be proffered way if there will be no possibility to cover all sampler types on Sdk side.
The text was updated successfully, but these errors were encountered: