Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update log component naming to reflect changes to the spec #3637

Closed
jack-berg opened this issue Sep 7, 2022 · 2 comments
Closed

Update log component naming to reflect changes to the spec #3637

jack-berg opened this issue Sep 7, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request logs Logging signal related

Comments

@jack-berg
Copy link
Member

The spec PR #2676 to add a log API and the followup PR #2768 to align log API / SDK component naming impacts SDKs which have been prototyping the log SDK, including dotnet. The changes include:

  • LogEmitterProvider -> LoggerProvider
  • LogEmitter -> Logger
  • LogProcessor -> LogRecordProcessor
  • LogExporter -> LogRecordExporter

SDKs are encouraged to update component names to reflect the specification changes.

PR #2768 resets the log section of the spec compliance matrix to reflect the changes.

@reyang
Copy link
Member

reyang commented Sep 13, 2022

OpenTelemetry .NET is using Generic (e.g. BaseExporter<LogRecord> and BaseProcessor<LogRecord>) across the logs/metrics/traces.

LogEmitterProvider/LogEmitter need to be changed @CodeBlanch.

@CodeBlanch CodeBlanch self-assigned this Sep 13, 2022
@CodeBlanch CodeBlanch added the logs Logging signal related label Sep 13, 2022
@utpilla utpilla modified the milestones: 1.6.0, 1.7.0 Aug 8, 2023
@utpilla utpilla modified the milestones: 1.7.0, 1.8.0 Oct 17, 2023
@vishweshbankwar vishweshbankwar modified the milestones: 1.8.0, 1.9.0 Mar 12, 2024
@CodeBlanch CodeBlanch modified the milestones: 1.9.0, Future Mar 13, 2024
@CodeBlanch
Copy link
Member

LoggerProvider work is done. Promoting it to public is covered by #5442.
Logger work is done. Promoting it to public is covered by #4433.

Nothing was done for...

LogProcessor -> LogRecordProcessor
LogExporter -> LogRecordExporter

...as those never existed, we just have base classes.

@CodeBlanch CodeBlanch removed this from the Future milestone Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request logs Logging signal related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants