Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for metrics in HttpClient for .NET framework #4764

Closed
pyohannes opened this issue Aug 11, 2023 · 4 comments · Fixed by #4870
Closed

Implement support for metrics in HttpClient for .NET framework #4764

pyohannes opened this issue Aug 11, 2023 · 4 comments · Fixed by #4870
Labels
enhancement New feature or request

Comments

@pyohannes
Copy link
Contributor

Feature Request

Is your feature request related to a problem?

Currently, HttpClient instrumentation supports metrics for .NET (Core), but not for .NET framework. This is mentioned in a warning in the documentation.

This is unexpected and seen as a bug by users I've interacted with. Users of e. g. the auto-instrumentation packages or other instrumentation that packages that use HttpClient under the hood will likely not find the warning.

Describe the solution you'd like:

Adding support for metrics also for .NET framework would be a desired solution.

Describe alternatives you've considered.

Users who currently face this issue have to either provide their own instrumentation library, add manual instrumentation, or create metrics from fully sampled traces.

Additional Context

Related Slack discussion
Warning in the documentation

@pyohannes pyohannes added the enhancement New feature or request label Aug 11, 2023
@matt-hensley
Copy link
Contributor

I've started on a proposed PR for this and will have a draft ready next week.

@alejandrocarrasquilla
Copy link

@matt-hensley Any updates on this change?
We are interested in this functionality. We are specially interested in the implementation that does not rely on having traces enabled.
Thanks

@Jazaret
Copy link

Jazaret commented Sep 7, 2023

Is there any update on this? Our team is depending on HttpClient metrics for .NET Framework.

@matt-hensley
Copy link
Contributor

After feedback from maintainers on #4768 I am taking a different approach for the metrics implementation.

This should allow for generation of traces and metrics independently, as opposed to the previous PR that required tracing to be enabled, and for a particular trace to be sampled and recorded.

Currently iterating on this new approach and working through the tests as the current instrumentation is only trace focused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants