Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IncludeStateTrace internal ? #4888

Closed
yassinebennani opened this issue Sep 26, 2023 · 4 comments
Closed

IncludeStateTrace internal ? #4888

yassinebennani opened this issue Sep 26, 2023 · 4 comments
Labels
question Further information is requested Stale Issues and pull requests which have been flagged for closing due to inactivity

Comments

@yassinebennani
Copy link

Question

Use Github Discussions.

Hello Guys,

Can someone please explain to me what is the reason behind defining the property IncludeStateTrace of the class OpenTelemetryLoggerOptions as internal and not public ?

Thank you
@yassinebennani yassinebennani added the question Further information is requested label Sep 26, 2023
@Kielek
Copy link
Contributor

Kielek commented Sep 26, 2023

See PR: #4334

especially #4334 (comment)

Nobody make a request/pr for that.

@CodeBlanch
Copy link
Member

@yassinebennani We removed it from the public API because we were unsure on the use case and if it was really useful/needed. You want to include trace state on your logs? Can you provide a little detail about the why? I'm interested in how you plan to use that data and why it would be helpful to have.

@github-actions GitHub Actions
Copy link
Contributor

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this issue is still a concern.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Kielek @yassinebennani @CodeBlanch