-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make OtlpLogExporter public #4971
Comments
@AB027PS Thanks for raising this. Would you be interested in sending the PR for change? @open-telemetry/dotnet-maintainers FYI |
Even if the Exporter is made public, how do you intend to use this? If your goal is to nlog -> Otel, then this is probably what you want? |
According to OpenTelemetry own documentation, then one is encouraged to use a Collector, instead of sending directly.
Thus the application is not affected by OpenTelemetry-connectivity-downtime, and application doesn't have to know about OpenTelemetry-connection-details. Could be nice if the FileLog-Receiver had an official Json-Schema, that required minimum parsing. Then it would "just" be a matter of configuring NLog to write to a JSON-file. |
@cijothomas I am the same person as AB027PS, only I don't currently have access to that account, so I'll answer this way. The repo with the target is work in progress, so I'm not going to make it public yet, but here is a text file with the target, since I couldn't upload a .cs file. I'm making use of the bridge API, but the only missing piece is OtlpLogExporter. I also encountered #4970, but that is a separate issue. |
Not sure how is this related to this issue? |
Only to mention alternative with using Collector, instead of sending directly using exporter. Thus details about OpenTelemetry-connectivity-details are decoupled from the the application. |
Feature Request
I'm trying to create an NLog target which would export logs using the OpenTelemetry protocol. Having access to this class would allow me to create a sort of an internal logger, which would export incoming logs using the existing infrastructure from the OpenTelemetry.Exporter.OpenTelemetryProtocol library.
Describe the solution you'd like:
I'd like the OtlpLogExporter class to be made public.
Describe alternatives you've considered.
An alternative is instantiating the class using reflection or reimplementing much of the OpenTelemetry.Exporter.OpenTelemetryProtocol library, neither of which is ideal. As far as I know, there isn't a public way to create an instance of OtlpLogExporter .
The text was updated successfully, but these errors were encountered: