Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exemplar - remove ExemplarFilter API #5333

Closed
cijothomas opened this issue Feb 9, 2024 · 3 comments
Closed

Exemplar - remove ExemplarFilter API #5333

cijothomas opened this issue Feb 9, 2024 · 3 comments
Assignees
Labels
metrics Metrics signal related

Comments

@cijothomas
Copy link
Member

Recent spec changes removed the notion of custom ExemplarFilter and only allows 3 built-in values (on/off/tracebased).
We need to remove ExemplarFilter and adhere to this new spec. (ExemplarFilter was only public in experimental builds, but this is breaking change for those releases)

https://github.com/open-telemetry/opentelemetry-specification/pull/3820/files

@cijothomas cijothomas added the metrics Metrics signal related label Feb 9, 2024
@rajkumar-rangaraj
Copy link
Contributor

The OpenTelemetry Specification doesn't explicitly prohibit the creation of custom exemplar filters, while it mandates support for standard filters like AlwaysOn, AlwaysOff, and TraceBased. Given this, should we still consider the removal of the ExemplarFilter API?

Should we drive clarity in the spec to call out that custom exemplar filters are not supported?

@cijothomas
Copy link
Member Author

https://github.com/open-telemetry/opentelemetry-specification/pull/3820/files
It does not prohibit, but does not support either. I don't see a need for keeping Filter - it is not particularly useful, as it does not have access even to meter.name or instrument.name, so can't use it for customizing filter based on the meter/instrument.

@CodeBlanch
Copy link
Member

Work completed: #5404 and #5408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Metrics signal related
Projects
None yet
Development

No branches or pull requests

3 participants