-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Release automation improvements #5657
Merged
CodeBlanch
merged 38 commits into
open-telemetry:main
from
CodeBlanchOrg:repo-automation-bot-pat
May 29, 2024
Merged
[repo] Release automation improvements #5657
CodeBlanch
merged 38 commits into
open-telemetry:main
from
CodeBlanchOrg:repo-automation-bot-pat
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5657 +/- ##
==========================================
+ Coverage 83.38% 85.74% +2.35%
==========================================
Files 297 254 -43
Lines 12531 11054 -1477
==========================================
- Hits 10449 9478 -971
+ Misses 2082 1576 -506
Flags with carried forward coverage won't be shown. Click here to find out more. |
vishweshbankwar
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
OpenTelemetryBot
Details
See: open-telemetry/community#2127 (comment)
By default actions performed in workflows (push, create PR, create release, etc.) don't trigger other workflows. This means when the automation does things like open PRs builds won't be run. Pushing a tag can't trigger the release job. There were some tricks employed previously like calling other workflows but it didn't work across the board. What this PR does is switch to
OpenTelemetryBot
which is more or less a normal account. UsingOpenTelemetryBot
allows the same triggers to work for the manual process and the automation.Test runs:
Merge requirement checklist