[repo] Reduce explicit package references on newer TFM's #5659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeBlanch
reviewed
May 29, 2024
src/OpenTelemetry.Exporter.Console/OpenTelemetry.Exporter.Console.csproj
Outdated
Show resolved
Hide resolved
thompson-tomo
force-pushed
the
chore/#5658_PackageCleanup
branch
3 times, most recently
from
cac2b13 to
572c8a4
Compare
vishweshbankwar
approved these changes
May 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5659 +/- ##
==========================================
+ Coverage 83.38% 85.80% +2.42%
==========================================
Files 297 254 -43
Lines 12531 11054 -1477
==========================================
- Hits 10449 9485 -964
+ Misses 2082 1569 -513
Flags with carried forward coverage won't be shown. Click here to find out more. |
thompson-tomo
force-pushed
the
chore/#5658_PackageCleanup
branch
from
572c8a4 to
e86e281
Compare
thompson-tomo
force-pushed
the
chore/#5658_PackageCleanup
branch
from
e86e281 to
4cfa935
Compare
CodeBlanch
changed the title
CodeBlanch
added
pkg:OpenTelemetry.Exporter.Console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5658
Changes
These changes have reduced the dependencies on Net 6 & in particular net 8 resulting in lower maintenance effort especially couple with the inversion of the conditions for protocol package which will result in no changes needed for net 9/10
Merge requirement checklist