-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark ActivityExtensions.RecordException obsolete #5665
Comments
I'm not sure if we can do that anytime soon. It's probably valid, but a bit premature. since the adoption rate of .NET 9 will be slow (since it's not LTS), we'll need this for around 2 years at least. If we develop a target for .NET 9 (I'm not sure if we will), it could be part of that. We could look to update the docs, but even then it's going to be confusing for anyone not using .NET 9. I think it should stay for a while, and it's not worth keeping an issue open for it until that happens. |
@martinjt, typically OTel SDK bumps System.DiagnosticsDiagnosticSource to the latest version. If this happen now, there should be no blocker to redirect users to use new API. |
DS is out of band, so DS 9.0 can be used in any .NET versions, not just .NET 9. (OTel enforces that, as OTel always depend on the latest stable DS version.) Deprecating |
@cijothomas, putting to 1.10.0 to do not forget about this. |
Totally my bad, .NET 9 threw me, completely forget it was in DS. |
Move it out of 1.10 due to lack of owner. If anyone can lend hands, please reply here and we can re-add for 1.10 |
Activity.AddException
will be added in .NET 9 (dotnet/runtime#53641). ShouldActivityExtensions.RecordException
then be deprecated?The text was updated successfully, but these errors were encountered: