Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial of getting-started-aspnetcore is not working as it refers un-released API #5686

Closed
konjac opened this issue Jun 11, 2024 · 2 comments
Closed

Tutorial of getting-started-aspnetcore is not working as it refers un-released API #5686

konjac opened this issue Jun 11, 2024 · 2 comments
Labels
question Further information is requested

Comments

@konjac
Copy link

konjac commented Jun 11, 2024

What is the question?

The sample in README is actually not working now.

The code(https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/docs/logs/getting-started-aspnetcore/Program.cs) is using the API of OpenTelemetryBuilder.WithLogging, which is newly introduced in #5648 and not released yet. If users follow the document to install packages from public nuget feeds, they will hit compile error.

Additional context

No response
@konjac konjac added the question Further information is requested label Jun 11, 2024
@cijothomas
Copy link
Member

1.9.0.-rc.1 should have this. Can you update to that and see?

@vishweshbankwar
Copy link
Member

1.9.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@konjac @cijothomas @vishweshbankwar