Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] Fix TODOs, Refactor Buffer Size Handling, and Cleanup Environment Variables #6009

Conversation

rajkumar-rangaraj
Copy link
Contributor

Fixes Part of #5730
Design discussion issue #

Changes

Please provide a brief description of the changes here.

  • Fixed TODOs
  • Moved the logic for increasing buffer size for logs and metrics to use shared functionality like traces.
  • Updated method and variable names
  • Removed the experimental environment variable as it is no longer required.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@rajkumar-rangaraj rajkumar-rangaraj requested a review from a team as a code owner December 3, 2024 06:14
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 10 lines in your changes missing coverage. Please review.

Project coverage is 86.33%. Comparing base (0c775e5) to head (670f614).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ementation/Serializer/ProtobufOtlpLogSerializer.cs 44.44% 5 Missing ⚠️
...ntation/Serializer/ProtobufOtlpMetricSerializer.cs 44.44% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6009      +/-   ##
==========================================
+ Coverage   86.16%   86.33%   +0.16%     
==========================================
  Files         257      257              
  Lines       11690    11685       -5     
==========================================
+ Hits        10073    10088      +15     
+ Misses       1617     1597      -20     
Flag Coverage Δ
unittests-Project-Experimental 86.27% <73.68%> (+0.49%) ⬆️
unittests-Project-Stable 86.22% <73.68%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lder/OpenTelemetryBuilderOtlpExporterExtensions.cs 100.00% <ø> (ø)
...etryProtocol/Implementation/ExperimentalOptions.cs 89.47% <ø> (+3.11%) ⬆️
...tation/ExportClient/Grpc/GrpcStatusDeserializer.cs 87.40% <100.00%> (+0.09%) ⬆️
...tation/OpenTelemetryProtocolExporterEventSource.cs 87.67% <100.00%> (+0.90%) ⬆️
...entation/Serializer/ProtobufOtlpTraceSerializer.cs 93.43% <ø> (+0.71%) ⬆️
...TelemetryProtocol/OtlpExporterOptionsExtensions.cs 96.90% <100.00%> (ø)
....Exporter.OpenTelemetryProtocol/OtlpLogExporter.cs 100.00% <100.00%> (+27.50%) ⬆️
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 80.76% <100.00%> (+24.01%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 89.28% <100.00%> (ø)
...ementation/Serializer/ProtobufOtlpLogSerializer.cs 95.41% <44.44%> (-3.77%) ⬇️
... and 1 more

... and 6 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 305597d into open-telemetry:main Dec 5, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants