Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore ShouldSample's argument for both AlwaysOnSample and AlwaysOffSampler #6023

Closed
wants to merge 2 commits into from
Closed

Ignore ShouldSample's argument for both AlwaysOnSample and AlwaysOffSampler #6023

wants to merge 2 commits into from

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Dec 12, 2024

Changes

Slightly more explicit about the AlwaysOn and Off samplers not using the argument in their overridden function.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Dec 12, 2024
@mic-max
Copy link
Contributor Author

mic-max commented Dec 12, 2024

I'll close this since it conflict with StyleCop rule SA1313 and the public API.

@mic-max mic-max closed this Dec 12, 2024
@mic-max mic-max deleted the patch-1 branch December 12, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mic-max