Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Samplers to match spec. #941

Closed
cijothomas opened this issue Jul 29, 2020 · 1 comment · Fixed by #1037
Closed

Fix Samplers to match spec. #941

cijothomas opened this issue Jul 29, 2020 · 1 comment · Fixed by #1037
Assignees
@rajkumar-rangaraj
Labels
enhancement New feature or request pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Milestone
0.5.0-beta (Beta 2)

Comments

@cijothomas
Copy link
Member

Sampling result is a binary now, but it should be an enum to match spec.
ActivityProcessors and ActivityExporters are called without regard to Sampler outcome. This must be fixed to match the spec.
@cijothomas cijothomas added the enhancement New feature or request label Jul 29, 2020
@cijothomas cijothomas added this to the 0.5.0-beta (Beta 2) milestone Jul 29, 2020
@cijothomas cijothomas added pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package priority:p1 labels Jul 29, 2020
This was referenced Jul 29, 2020
Closed
Closed
@cijothomas
Copy link
Member Author

Issue described here #953 is not going to be addressed in 0.5.0-beta release. It requires support from .NET and will not be part of preview8 of diagnosticsource

@cijothomas cijothomas mentioned this issue Aug 5, 2020
Merged
2 tasks
@CodeBlanch CodeBlanch mentioned this issue Aug 5, 2020
Merged
@rajkumar-rangaraj rajkumar-rangaraj mentioned this issue Aug 10, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajkumar-rangaraj rajkumar-rangaraj

Labels
enhancement New feature or request pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Milestone
0.5.0-beta (Beta 2)
Development

Successfully merging a pull request may close this issue.

Fix Samplers to match spec
2 participants
@cijothomas @rajkumar-rangaraj