Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commitChangesToNewBranch failed: invalid merge #47

Open
jpkrohling opened this issue Dec 9, 2021 · 6 comments
Open

commitChangesToNewBranch failed: invalid merge #47

jpkrohling opened this issue Dec 9, 2021 · 6 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jpkrohling
Copy link
Member

When trying to release OpenTelemetry Collector Contrib v0.41.0, once dealing with #46 manually, I ran into the following problem. I noticed that the branch was identical to the state of my workspace after the last run of the multimod. Is this the reason for the failure?

===== Module Set: contrib-base =====
Updating versions for module set...
Updating all module versions in go.mod files...
git branch prerelease_contrib-base_v0.41.0
Committing changes to git with message 'Prepare contrib-base for version v0.41.0'
commitChangesToNewBranch failed: could not commit changes: could not commit changes to git: branch config: invalid merge
make: *** [Makefile:302: multimod-prerelease] Error 1

$ git st
On branch prerelease_contrib-base_v0.41.0
nothing to commit, working tree clean

$ git version
git version 2.33.1

$ git log -1
commit fc4a73eb9ebdeb02c38e67eca9f0f160fa4ae464 (HEAD -> prerelease_contrib-base_v0.41.0, jpkrohling/core/issue4523)
Author: Juraci Paixão Kröhling <juraci@kroehling.de>
Date:   Thu Dec 9 10:46:18 2021 +0100

    gomodtidy
    
    Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@mx-psi
Copy link
Member

mx-psi commented Mar 16, 2022

I also ran into this while doing the opentelemetry-collector v0.47.0 release. I fixed it by nuking the repo and cloning again, but I am not sure why that solved the problem.

@pellared
Copy link
Member

@mx-psi @jpkrohling Is this issue still valid? Personally, I have not encountered it for several months.

@pellared pellared added the question Further information is requested label Jun 20, 2023
@mx-psi
Copy link
Member

mx-psi commented Jun 20, 2023

I did not encounter it on the last two releases for which I was a release manager

@pellared pellared closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2023
@mx-psi
Copy link
Member

mx-psi commented Oct 4, 2024

I saw this again during the v0.111.0 release

@mx-psi
Copy link
Member

mx-psi commented Oct 4, 2024

Here are the error logs:

❯ make push-tags MODSET=contrib-base
cd /home/user/Source/otel/opentelemetry-collector-contrib/internal/tools && GOOS="" go build -o /home/user/Source/otel/opentelemetry-collector-contrib/.tools/multimod -trimpath go.opentelemetry.io/build-tools/multimod
/home/user/Source/otel/opentelemetry-collector-contrib/.tools/multimod verify
Using versioning file /home/user/Source/otel/opentelemetry-collector-contrib/versions.yaml
PASS: All modules exist in exactly one set.
PASS: All module versions are valid, and no module sets have same non-zero major version.
Finished checking all stable modules' dependencies.
PASS: Module sets successfully verified.
set -e; for tag in `/home/user/Source/otel/opentelemetry-collector-contrib/.tools/multimod tag -m contrib-base -c HEAD --print-tags | grep -v "Using" `; do \
        echo "pushing tag ${tag}"; \
        git push git@github.com:open-telemetry/opentelemetry-collector-contrib.git ${tag}; \
done;
Using versioning file /home/user/Source/otel/opentelemetry-collector-contrib/versions.yaml
Tagging commit 47cd38d9815a854873962c17aa8df4bbe71268d8:
v0.111.0
unable to tag modules: unable to load repo config: branch config: invalid merge

@pellared pellared reopened this Oct 4, 2024
@pellared pellared added bug Something isn't working help wanted Extra attention is needed and removed question Further information is requested labels Oct 4, 2024
@evan-bradley
Copy link

Just another report, I saw this while doing the v0.112.0 release. Cloning a fresh copy of the repository also fixed it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants