Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XRay Remote Sampler does not preserve Rule reservoir upon sampling rules update #3619

Closed
jj22ee opened this issue Mar 23, 2023 · 1 comment
Closed

XRay Remote Sampler does not preserve Rule reservoir upon sampling rules update #3619

jj22ee opened this issue Mar 23, 2023 · 1 comment
Milestone
untracked

Comments

@jj22ee
Copy link
Contributor

jj22ee commented Mar 23, 2023

Get Sampling Targets (GST) Polling Interval is set to 10 seconds. Get Sampling Targets provides a reservoir and quota for sampling rules.
Get Sampling Rules (GSR) Polling Interval is configurable by the user.

GST will update a previously polled Rule's reservoir in each poll
GSR will reset the rule including the rule's reservoir in each poll. This means that after a GSR poll, there is no quota available to be used for sampling. This becomes immediately apparent when GSR polling interval is set to <10s, where it can be noticed that there is no available quota for sampling most of the time.

When GSR is polled and the rule's are updated, Rule reservoirs should be preserved.
@jj22ee jj22ee mentioned this issue Mar 23, 2023
Merged
@jj22ee
Copy link
Contributor Author

jj22ee commented May 3, 2023

PR merged. Closing.

@jj22ee jj22ee closed this as completed May 3, 2023
@pellared pellared added this to the untracked milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

No branches or pull requests
2 participants
@pellared @jj22ee