Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove otelkit #4085

Closed
pellared opened this issue Jul 17, 2023 · 1 comment
Closed

Remove otelkit #4085

pellared opened this issue Jul 17, 2023 · 1 comment
Assignees
@pellared
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelkit
Milestone
v1.20.0/v0.45.0

Comments

@pellared
Copy link
Member

pellared commented Jul 17, 2023 •
edited
Loading

Problem Statement

  1. The instrumentation is VERY go-kit specific it does not follow any OpenTelemetry Semantic Conventions (e.g. for HTTP)
  2. OTel maintainers and approvers are on low capacity and lack expertise on go-kit. See:

    opentelemetry-go-contrib/CODEOWNERS

    Line 36 in 9437f9b

    instrumentation/github.com/go-kit/kit/otelkit/ @open-telemetry/go-approvers
  3. Tther tracing instrumentation can be found under https://github.com/go-kit/kit/tree/master/tracing
  4. The currently preferred way according to our recommendation is to no not have the instrumentation in this repository

Proposed Solution

Deprecate https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrumentation/github.com/go-kit/kit/otelkitin next release.

Afterwards, as part of a subsequent release, remove the module from codebase and from the OTel Registry (https://opentelemetry.io/ecosystem/registry/adding/)

Additional Context

See go-kit/kit#1266
@pellared pellared added enhancement New feature or request area: instrumentation Related to an instrumentation package instrumentation: otelkit labels Jul 17, 2023
@pellared pellared mentioned this issue Jul 21, 2023
Merged
@pellared pellared self-assigned this Jul 27, 2023
@pellared pellared mentioned this issue Jul 27, 2023
Closed
@pellared pellared added this to the v0.44.0 milestone Aug 9, 2023
@pellared
Copy link
Member Author

Closing per #4295

@RangelReale RangelReale mentioned this issue Sep 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelkit
Projects
None yet
Milestone
v1.20.0/v0.45.0
Development

No branches or pull requests
1 participant
@pellared