Upgrade to semconv/v1.17.0 #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3182 +/- ##
=======================================
+ Coverage 69.5% 74.6% +5.1%
=======================================
Files 147 152 +5
Lines 6859 6955 +96
=======================================
+ Hits 4772 5194 +422
+ Misses 1971 1624 -347
- Partials 116 137 +21
|
MrAlias
force-pushed
the
bump-semconv-v1.17
branch
from
b9bebd2 to
7c3b1f6
Compare
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
|
I'm looking into the test failure on Windows for otelgrpc... |
12 tasks
Fixed in d18cfe2. Looks like the issue was on Windows the connection setup to a fake target hung indefinitely causing a goroutine to be abandoned. This was resolved by adding the |
Aneurysm9
approved these changes
Jan 27, 2023
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
MadVikingGod
approved these changes
Jan 27, 2023
This was referenced Feb 26, 2023
mlaflamm
reviewed
May 2, 2023
Comment on lines
+218
to
222
| attributes := append(labeler.Get(), httpconv.ServerRequest(h.server, r)...) | ||
| if rww.statusCode > 0 { | ||
| attributes = append(attributes, semconv.HTTPStatusCodeKey.Int(rww.statusCode)) | ||
| } | ||
| h.counters[RequestContentLength].Add(ctx, bw.read, attributes...) |
There was a problem hiding this comment.
ServerRequest returns trace attributes not appropriate for metric. This change is adding high cardinality attributes to metric (#3765).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
semconvuse to the new, unreleased,v1.17.0packagehttpconvandnetconvpacakges, and update any directsemconvreferences to rely on new semantic conventions