From 9b7df609f94b82eb358d9e30fd9ca850814f0208 Mon Sep 17 00:00:00 2001 From: Anton Manakin Date: Thu, 9 May 2024 21:44:42 +0300 Subject: [PATCH] fix test comments and changelog --- CHANGELOG.md | 2 +- sdk/trace/trace_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 98915b58e26f..eb8eac9e2388 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,7 +24,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm - De-duplicate map attributes added to a `Record` in `go.opentelemetry.io/otel/sdk/log`. (#5230) - The `go.opentelemetry.io/otel/exporters/stdout/stdoutlog` exporter won't print `AttributeValueLengthLimit` and `AttributeCountLimit` fields now, instead it prints the `DroppedAttributes` field. (#5272) - Improved performance in the `Stringer` implementation of `go.opentelemetry.io/otel/baggage.Member` by reducing the number of allocations. (#5286) -- Span in `go.opentelemetry.io/otel/sdk/trace` will record links without span context if either non-empty `TraceState` or attributes are provided. (#5315) +- The `Span` in `go.opentelemetry.io/otel/sdk/trace` will record links without span context if either non-empty `TraceState` or attributes are provided. (#5315) ## [1.26.0/0.48.0/0.2.0-alpha] 2024-04-24 diff --git a/sdk/trace/trace_test.go b/sdk/trace/trace_test.go index 8ae44d17b823..e7ef786a1b3d 100644 --- a/sdk/trace/trace_test.go +++ b/sdk/trace/trace_test.go @@ -2083,7 +2083,7 @@ func TestAddLinkToNonRecordingSpan(t *testing.T) { _, err := endSpan(te, span) require.NoError(t, err) - // Add link after ending span + // Add link to ended, non-recording, span. The link should be dropped. span.AddLink(trace.Link{ SpanContext: sc, Attributes: attrs,