Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About RateLimitSampler and GuaranteedThroughputProbabilisticSampler #1074

Closed
j2gg0s opened this issue Aug 21, 2020 · 1 comment
Closed

About RateLimitSampler and GuaranteedThroughputProbabilisticSampler #1074

j2gg0s opened this issue Aug 21, 2020 · 1 comment
Milestone

Comments

@j2gg0s
Copy link

j2gg0s commented Aug 21, 2020

Do we have any plan to add RateLimitSampler and GuaranteedThroughputProbabilisticSampler

Like in jaeger:
https://github.com/jaegertracing/jaeger-client-go/blob/master/sampler.go#L189
https://github.com/jaegertracing/jaeger-client-go/blob/master/sampler.go#L249

@jmacd
Copy link
Contributor

jmacd commented Aug 21, 2020

I'm personally in favor of an unbiased Sampler that can attach concrete probabilities to the SpanData that it emits. Neither of these Samplers can do that.

I made a comment about how a Sampler can be unbiased, emit probabilities, and limit throughput here: open-telemetry/opentelemetry-specification#570 (comment)

@j2gg0s j2gg0s closed this as completed Sep 1, 2020
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants