Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ProbabilitySampler to TraceIdRatioBasedSampler #1083

Closed
MrAlias opened this issue Aug 24, 2020 · 0 comments · Fixed by #1115
Closed

Rename ProbabilitySampler to TraceIdRatioBasedSampler #1083

MrAlias opened this issue Aug 24, 2020 · 0 comments · Fixed by #1115
Assignees
@evantorrie
Labels
area:trace Part of OpenTelemetry tracing help wanted Extra attention is needed pkg:SDK Related to an SDK package
Milestone
RC1

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Aug 24, 2020

Implement this change: open-telemetry/opentelemetry-specification#611
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:trace Part of OpenTelemetry tracing release:required-for-ga help wanted Extra attention is needed labels Aug 24, 2020
@MrAlias MrAlias added this to the RC1 milestone Aug 27, 2020
@evantorrie evantorrie mentioned this issue Sep 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evantorrie evantorrie

Labels
area:trace Part of OpenTelemetry tracing help wanted Extra attention is needed pkg:SDK Related to an SDK package
Projects
None yet
Milestone
RC1
Development

Successfully merging a pull request may close this issue.

Change name of ProbabilitySampler to TraceIdRatioBased evantorrie/opentelemetry-go
2 participants
@MrAlias @evantorrie