You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now TraceFlags is just a bit, I think it is more extensible to have it like a struct type TraceFlags byte and expose helpers like IsSampled on this struct.
The text was updated successfully, but these errors were encountered:
The Go type system allows methods to be added to any types, not just structs, so I'm not sure that should motivate an underlying type change. That said, I think the downside of using a struct with the small increase in resource overhead might be outweighed by the potential extensibility.
What other fields do you anticipate being added to the TraceFlags type?
Right now TraceFlags is just a bit, I think it is more extensible to have it like a struct
type TraceFlags byte
and expose helpers likeIsSampled
on this struct.The text was updated successfully, but these errors were encountered: