Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "FollowsFrom" relationships #193

Closed
iredelmeier opened this issue Oct 11, 2019 · 8 comments
Closed

Remove "FollowsFrom" relationships #193

iredelmeier opened this issue Oct 11, 2019 · 8 comments

Comments

@iredelmeier
Copy link
Member

Reference is not defined in the specs. What does a follow from mean?

Originally posted by @bogdandrutu in #190

Note that this would affect FollowsFrom-based relationships in the OpenTracing bridge.

@jmacd
Copy link
Contributor

jmacd commented Oct 11, 2019

"Reference" may be a misleading term. I thought we called these relationships.

I think it will be a set-back if we remove FollowsFrom.

@iredelmeier
Copy link
Member Author

@jmacd that's my understanding too re: "relationships" instead of "references". The first line is a quote since I created this issue from a discussion in #190.

@rghetia
Copy link
Contributor

rghetia commented Oct 17, 2019

Use attribute "span.relation" = "childOf" or "followsFrom" in Link.

@lizthegrey
Copy link
Member

I'm confused though, doesn't Link lack the relation or RelationshipType field?

Is

Relation{
	SpanContext:      sc,
	RelationshipType: FollowsFromRelationship,
}

being replaced with:

Link {
	SpanContext: sc,
	Attributes []core.KeyValue
}

which lacks the RelationshipType field?

@lizthegrey
Copy link
Member

and how does this relate to #225

@jmacd
Copy link
Contributor

jmacd commented Nov 1, 2019

I feel we still have no substitute for "follows from", see here open-telemetry/opentelemetry-specification#337 (comment)

@lizthegrey
Copy link
Member

I chose to do #272 in order to implement Links at span creation time, rather than trying to munge FollowsFrom into a Link etc

@rghetia
Copy link
Contributor

rghetia commented Feb 13, 2020

fixed by #451

@rghetia rghetia closed this as completed Feb 13, 2020
hstan referenced this issue in hstan/opentelemetry-go Oct 15, 2020
…aws (#193)

* Bump github.com/aws/aws-sdk-go from 1.33.19 to 1.33.20 in /detectors/aws

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.33.19 to 1.33.20.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.33.19...v1.33.20)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants