Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate the v1.14 version of the semconv package #3276

Closed
MrAlias opened this issue Oct 12, 2022 · 3 comments · Fixed by #3566
Closed

Generate the v1.14 version of the semconv package #3276

MrAlias opened this issue Oct 12, 2022 · 3 comments · Fixed by #3566
Assignees

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Oct 12, 2022

The v1.14 version of the specification has been released. A new v1.14 version of semconv needs to be generated for this.

Blocked by #3191 which is working to add new HTTP semantic convention functionality due to upstream breaking changes.

@MrAlias MrAlias self-assigned this Nov 29, 2022
@MrAlias MrAlias changed the title Generate the v1.14 version of the semconv pacakge Generate the v1.14 version of the semconv package Dec 8, 2022
@MrAlias
Copy link
Contributor Author

MrAlias commented Jan 5, 2023

$ make semconv-generate
[ "v1.14.0" ] || ( echo "TAG unset: missing opentelemetry specification tag"; exit 1 )
[ "/home/tyler/code/opentelemetry-specification" ] || ( echo "OTEL_SPEC_REPO unset: missing path to opentelemetry specification repo"; exit 1 )
/home/tyler/go/src/go.opentelemetry.io/otel/.tools/semconvgen -i "/home/tyler/code/opentelemetry-specification/semantic_conventions/trace" -t ""semconv/"/template.j2" -s "v1.14.0"
panic: unable to render template: exit status 1
Traceback (most recent call last):
  File "/usr/local/bin/gen-semconv", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.8/site-packages/opentelemetry/semconv/main.py", line 67, in main
    semconv = parse_semconv(args, parser)
  File "/usr/local/lib/python3.8/site-packages/opentelemetry/semconv/main.py", line 38, in parse_semconv
    semconv.finish()
  File "/usr/local/lib/python3.8/site-packages/opentelemetry/semconv/model/semantic_convention.py", line 313, in finish
    fixpoint_ref = self.resolve_ref(semconv)
  File "/usr/local/lib/python3.8/site-packages/opentelemetry/semconv/model/semantic_convention.py", line 454, in resolve_ref
    raise ValidationError.from_yaml_pos(
opentelemetry.semconv.model.exceptions.ValidationError: Semantic Convention trace-exception reference `exception.type` but it cannot be found! - @2:5


goroutine 1 [running]:
main.main()
	/home/tyler/go/pkg/mod/go.opentelemetry.io/build-tools/semconvgen@v0.3.0/generator.go:61 +0x44e
make: *** [Makefile:213: semconv-generate] Error 2

Looking into the schema to see if there were changes. Might look into what the collector did here.

@MrAlias
Copy link
Contributor Author

MrAlias commented Jan 5, 2023

$ make semconv-generate
[ "v1.14.0" ] || ( echo "TAG unset: missing opentelemetry specification tag"; exit 1 )
[ "/home/tyler/code/opentelemetry-specification" ] || ( echo "OTEL_SPEC_REPO unset: missing path to opentelemetry specification repo"; exit 1 )
/home/tyler/go/src/go.opentelemetry.io/otel/.tools/semconvgen -i "/home/tyler/code/opentelemetry-specification/semantic_conventions/trace" -t ""semconv/"/template.j2" -s "v1.14.0"
panic: unable to render template: exit status 1
Traceback (most recent call last):
  File "/usr/local/bin/gen-semconv", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.8/site-packages/opentelemetry/semconv/main.py", line 67, in main
    semconv = parse_semconv(args, parser)
  File "/usr/local/lib/python3.8/site-packages/opentelemetry/semconv/main.py", line 38, in parse_semconv
    semconv.finish()
  File "/usr/local/lib/python3.8/site-packages/opentelemetry/semconv/model/semantic_convention.py", line 313, in finish
    fixpoint_ref = self.resolve_ref(semconv)
  File "/usr/local/lib/python3.8/site-packages/opentelemetry/semconv/model/semantic_convention.py", line 454, in resolve_ref
    raise ValidationError.from_yaml_pos(
opentelemetry.semconv.model.exceptions.ValidationError: Semantic Convention trace-exception reference `exception.type` but it cannot be found! - @2:5


goroutine 1 [running]:
main.main()
	/home/tyler/go/pkg/mod/go.opentelemetry.io/build-tools/semconvgen@v0.3.0/generator.go:61 +0x44e
make: *** [Makefile:213: semconv-generate] Error 2

Looking into the schema to see if there were changes. Might look into what the collector did here.

open-telemetry/opentelemetry-collector#6713 (review)

@Aneurysm9
Copy link
Member

Yup, looks like the same issue. open-telemetry/opentelemetry-go-build-tools#217 should unblock this by allowing us to point at the root of the spec conventions but request output of specific types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants