Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not silently drop invalid schema fields #3742

Closed
MrAlias opened this issue Feb 17, 2023 · 0 comments · Fixed by #3743
Closed

Do not silently drop invalid schema fields #3742

MrAlias opened this issue Feb 17, 2023 · 0 comments · Fixed by #3743
Assignees
@MrAlias
Labels
bug Something isn't working
Milestone
Schema v0.0.4

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Feb 17, 2023

Description

Parsing a schema file that contains invalid fields currently drops those fields1. This leads users to a false positive result.

Expected behavior

Error when a user provides invalid data to be parsed.

Footnotes

  1. https://github.com/open-telemetry/opentelemetry-specification/pull/3190#discussion_r1107904557 ↩
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
bug Something isn't working
Projects
None yet
Milestone
Schema v0.0.4
Development

Successfully merging a pull request may close this issue.

Do no silently drop unknown schema data MrAlias/opentelemetry-go
1 participant
@MrAlias