Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metric.WithUnit recommend using UCUM units #4380

Closed
pellared opened this issue Jul 28, 2023 · 0 comments · Fixed by #4418
Closed

metric.WithUnit recommend using UCUM units #4380

pellared opened this issue Jul 28, 2023 · 0 comments · Fixed by #4418

Comments

@pellared
Copy link
Member

Opportunistic question: Should we add some doc comments to https://pkg.go.dev/go.opentelemetry.io/otel/metric#WithUnit that we recommend using UCUM units?

Related to #4374 (comment)

Doing so in a separate PR sounds good to me.

Originally posted by @MrAlias in #4374 (comment)
@pellared pellared changed the title metric.WithUnit document that we recommend using UCUM units metric.WithUnit recommend using UCUM units Jul 28, 2023
@pellared pellared mentioned this issue Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metric: Recommend defining units in UCUM pellared/opentelemetry-go
1 participant
@pellared