You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The validation of the exponential histogram, already performed in sdk/metric/aggregation, is duplicated in the exponential histogram implementation (sdk/metric/internal/aggregate). The view will use the Err from ExponentialHistogram in sdk/metric/aggregation to validate the configuration prior to getting here:
Having a duplicate validation of the configuration here will lead to two parts of the code-base doing the same thing and introduce the possibility for many bugs.
Similar to the explicit bucket histogram, we should just assume the configuration passed here is valid and proceed.
The validation of the exponential histogram, already performed in
sdk/metric/aggregation
, is duplicated in the exponential histogram implementation (sdk/metric/internal/aggregate
). The view will use theErr
fromExponentialHistogram
insdk/metric/aggregation
to validate the configuration prior to getting here:opentelemetry-go/sdk/metric/view.go
Lines 98 to 105 in ab61991
Having a duplicate validation of the configuration here will lead to two parts of the code-base doing the same thing and introduce the possibility for many bugs.
Similar to the explicit bucket histogram, we should just assume the configuration passed here is valid and proceed.
Originally posted by @MrAlias in #4245 (comment)
The text was updated successfully, but these errors were encountered: