Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove context check on stdout exporters #5173

Closed
XSAM opened this issue Apr 7, 2024 · 1 comment · Fixed by #5189
Closed

Remove context check on stdout exporters #5173

XSAM opened this issue Apr 7, 2024 · 1 comment · Fixed by #5189
Assignees
@prasad-shirodkar
Labels
good first issue Good for newcomers help wanted Extra attention is needed pkg:exporter:stdout Related to the stdout exporter package
Milestone
v1.27.0

Comments

@XSAM
Copy link
Member

XSAM commented Apr 7, 2024 •
edited by pellared

There's no work being done. We recently decided we don't want to return an error in these situations.

Originally posted by @MrAlias in #5172 (comment)

stdouttrace and stdoutmetric exporters still have similar logic.
@XSAM XSAM changed the title Remove context check on stdout exporter Remove context check on stdout exporters Apr 7, 2024
@XSAM XSAM mentioned this issue Apr 7, 2024
Merged
@XSAM XSAM added the pkg:exporter:stdout Related to the stdout exporter package label Apr 7, 2024
@MrAlias MrAlias added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 8, 2024
@prasad-shirodkar
Copy link
Contributor

I am interested to work on this. Please feel free to assign to myself.

@prasad-shirodkar prasad-shirodkar mentioned this issue Apr 10, 2024
Merged
@MrAlias MrAlias added this to the v1.27.0 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prasad-shirodkar prasad-shirodkar

Labels
good first issue Good for newcomers help wanted Extra attention is needed pkg:exporter:stdout Related to the stdout exporter package
Projects
None yet
Milestone
v1.27.0
Development

Successfully merging a pull request may close this issue.

Remove context check on stdout exporters prasad-shirodkar/opentelemetry-go
3 participants
@MrAlias @XSAM @prasad-shirodkar