Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test TestBufferExporter/Shutdown/ContextCancelled #5179

Closed
pellared opened this issue Apr 8, 2024 · 2 comments · Fixed by #5261
Closed

Flaky test TestBufferExporter/Shutdown/ContextCancelled #5179

pellared opened this issue Apr 8, 2024 · 2 comments · Fixed by #5261
Assignees
@XSAM
Labels
area:logs Part of OpenTelemetry logs pkg:SDK Related to an SDK package
Milestone
v1.27.0

Comments

@pellared
Copy link
Member

pellared commented Apr 8, 2024 •
edited

Flaky test: TestBufferExporter/Shutdown/ContextCancelled

Failed action: https://github.com/open-telemetry/opentelemetry-go/actions/runs/8602496452/job/23572195909?pr=5163

go test -timeout 60s -race ./sdk/log/...
--- FAIL: TestBufferExporter (0.00s)
    --- FAIL: TestBufferExporter/Shutdown (0.00s)
        --- FAIL: TestBufferExporter/Shutdown/ContextCancelled (0.00s)
            exporter_test.go:393: 
                	Error Trace:	/home/runner/work/opentelemetry-go/opentelemetry-go/sdk/log/exporter_test.go:393
                	Error:      	Target error should be in err chain:
                	            	expected: "context canceled"
                	            	in chain: "assert.AnError general error for testing"
                	Test:       	TestBufferExporter/Shutdown/ContextCancelled

Originally posted by @pellared in #5163 (comment)
@pellared pellared added pkg:SDK Related to an SDK package area:logs Part of OpenTelemetry logs labels Apr 8, 2024
@MrAlias
Copy link
Contributor

MrAlias commented Apr 8, 2024

Can you link the action failure?

@pellared
Copy link
Member Author

pellared commented Apr 8, 2024

Done.

@pellared pellared changed the title Flaky test: TestBufferExporter/Shutdown/ContextCancelled Flaky test TestBufferExporter/Shutdown/ContextCancelled Apr 8, 2024
@XSAM XSAM self-assigned this Apr 24, 2024
@XSAM XSAM mentioned this issue Apr 24, 2024
Merged
@MrAlias MrAlias added this to the v1.27.0 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XSAM XSAM

Labels
area:logs Part of OpenTelemetry logs pkg:SDK Related to an SDK package
Projects
Go: Logs (GA)
Status: Done
Milestone
v1.27.0
Development

Successfully merging a pull request may close this issue.

Fix flaky test TestBufferExporter/Shutdown/ContextCancelled XSAM/opentelemetry-go
3 participants
@pellared @MrAlias @XSAM