Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no-op processor #5580

Open
pellared opened this issue Jul 5, 2024 · 1 comment · May be fixed by #5618
Open

Add no-op processor #5580

pellared opened this issue Jul 5, 2024 · 1 comment · May be fixed by #5618
Labels
area:logs Part of OpenTelemetry logs blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made enhancement New feature or request pkg:SDK Related to an SDK package

Comments

@pellared
Copy link
Member

pellared commented Jul 5, 2024 •
edited

Blocked by:

Here is another usage of an no-op processor in a processor implementation.

I think we can think about adding it the the SDK as it can be commonly used in processor decorators.

See also: open-telemetry/opentelemetry-go-contrib#5817 (comment)

Originally posted by @pellared in open-telemetry/opentelemetry-go-contrib#5861 (comment)

From open-telemetry/opentelemetry-specification#4090 (comment):

It is always implied that implementations can go beyond the spec. If there is no desire to ensure common implementation, adding this only adds cruft and potential confusion.

As far as I understand, adding a no-op processor to the SDK would not make the it not compliant with the specification (the SDK should be still compliant).
@pellared pellared added pkg:SDK Related to an SDK package area:logs Part of OpenTelemetry logs enhancement New feature or request labels Jul 5, 2024
@pellared pellared mentioned this issue Jul 8, 2024
Draft
@pellared
Copy link
Member Author

I suggest to postpone until open-telemetry/opentelemetry-specification#4067 is resolved.

@pellared pellared added the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Jul 10, 2024
@pellared pellared linked a pull request Jul 15, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:logs Part of OpenTelemetry logs blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made enhancement New feature or request pkg:SDK Related to an SDK package
Projects
Go: Logs (Post-GA)
Status: Blocked
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sdk/log: Add NoopProcessor pellared/opentelemetry-go
1 participant
@pellared