Upgrade use of semconv to v1.24.0 #4754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4754 +/- ##
=====================================
Coverage 82.3% 82.3%
=====================================
Files 226 226
Lines 18401 18406 +5
=====================================
+ Hits 15148 15153 +5
Misses 2969 2969
Partials 284 284
|
pellared
commented
Dec 12, 2023
pellared
changed the title
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
pellared
changed the title
pellared
changed the title
pellared
added
the
blocked:specification
pellared
changed the title
pellared
changed the title
MrAlias
approved these changes
Jan 9, 2024
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
pellared
changed the title
pellared
removed
the
blocked:specification
hanyuancheung
approved these changes
Jan 10, 2024
dmathieu
approved these changes
Jan 10, 2024
|
I plan to merge this tomorrow. |
MadVikingGod
approved these changes
Jan 10, 2024
jufemaiz
reviewed
Jan 31, 2024
| @@ -25,6 +25,8 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
|
|
|||
| ### Changed | |||
|
|
|||
| - Upgrade all use of `go.opentelemetry.io/otel/semconv` to use `v1.24.0`. (#4754) | |||
| - Update transformations in `go.opentelemetry.io/otel/exporters/zipkin` to follow `v1.19.0` version of the OpenTelemetry specification. (#4754) | |||
There was a problem hiding this comment.
Looks a lot more like it's using v1.24.0. May lead to confusion?
There was a problem hiding this comment.
You are correct. Thanks ❤️
pellared
added a commit
to pellared/opentelemetry-go
that referenced
this pull request
Jan 31, 2024
pellared
added a commit
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4753
Related to: