Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

presets.kubernetesAttributes with role and rolebinding #1099

Closed
Marty1703 opened this issue Mar 27, 2024 · 1 comment
Closed

presets.kubernetesAttributes with role and rolebinding #1099

Marty1703 opened this issue Mar 27, 2024 · 1 comment

Comments

@Marty1703
Copy link

Since version 0.97 of the otel-collector-contrib it is possible to use the k8sattributes processor without cluster wide permissions, only a single namespace.

This functionality has been added with:
open-telemetry/opentelemetry-collector-contrib#31673
open-telemetry/opentelemetry-collector-contrib#14742

All documentation can be found here:
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/k8sattributesprocessor#namespace-scoped-rbac

I would love to have this functionality build in within the helm chart using the presets.kubernetesAttributes

Some possible options to include would be:

presets:
  kubernetesAttributes:
    filter: 
      namespace: <WORKLOAD_NAMESPACE>

or

presets:
  kubernetesAttributes:
    namespaceScoped: true (default false)
@TylerHelmuth
Copy link
Member

I'm glad this feature exists, but I'm not sure it should be incorporated into the preset. We don't like to configure components via the preset and it is a simpler opinionated solution to give the collector access to all namespaces.

@TylerHelmuth TylerHelmuth closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants