-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding ebpf collector #835
Comments
Thanks for opening this issue @povilasv 😍 To better understand, below you can find an image explaining the collector architecture I got from the Splunk helm chart, available here. With that in mind, I would say that all the listed components should be available in only one helm chart. Regarding the Chart Maintenance, I'm more than available to work on this, if everybody is Ok with that. |
This chart can be deployed independently from a collector chart. It indeed contains 3 components that should be deployed together. |
Based on this I definitely think it should be its own chart. |
➕ 1 ☝🏽 |
1 similar comment
➕ 1 ☝🏽 |
Look we have an agreement! |
@nicolastakashi before we review the PR a few more questions:
|
Sure!
As we can see on the current eBPF collector architecture, this collector is composed of 3 main components: Kernel CollectorIt's the brain of this solution, this component is responsible for attaching eBPF probs and collecting (at this moment), network information at the Kernel Level and pushing the collected information into the next component named Reducer. For more deep details about the Kernel Collector component, I do recommend checking this doc available on the project repository. Reducer (Required)The role of the reducer is to combine information received from eBPF collectors into metrics. Metrics are aggregated across time and dimensions. The output is in the form of timestamped data points, which can be stored in a time-series database. For more deep details about the Reducer component, I do recommend checking this doc available on the project repository. Kubernetes CollectorThe Kubernetes collector gathers information from a Kubernetes API server on events like pod creation and deletion and pushes that information to the Reducer. The information collected by the Kubernetes Collector will be used to enrich the information collected by the Kernel Collector adding information such as source and destination. This is an optional component, but we do recommend users use it to have better visibility. The project maintainers aim to simplify this component since it's composed of two different binaries written in two different languages C and Go, as you can see here. So this is the component that I see in the future having some changes (maybe breaking), but please @atoulme give me your view about that. For more deep details about the Kubernetes Collector component, I do recommend checking this doc available on the project repository. Cloud CollectorThe cloud collector gathers metadata from a cloud provider and pushes that information to the Reducer. Currently, there's only support for AWS and GCP For more deep details about the Cloud Collector component, I do recommend checking this doc available on the project repository.
From my understanding yes, I can't see a reason why this is not possible, wdyt @atoulme?
In general, I would say stable, most of the things are working on top of the existing components so probably only changing the image version should be required. The only component that I can see a possible breaking change in the future is the Kubernetes Collector. Of course, the project may evolve in the future and new components appear.
@atoulme I need your help with that. I'm not part of OTel eBPF Sig but I'm available to help with it. @TylerHelmuth let me know if the description is good 😄 |
@nicolastakashi thank you for those details. @atoulme we'll need an answer to Also, as a side note, using the word |
I can volunteer to be a code owner of this chart. No, we have not worked out our naming. I will open an issue for this. |
I think this chart meets our requirements. @open-telemetry/helm-approvers do you agree? |
I support it |
I support |
Hey folks! |
Yes |
Hey folks @TylerHelmuth @atoulme it's ready for review: #855 Just need to write the readme.md but it's fine for a first look |
@nicolastakashi thanks for working on this. I will slowly take a look over the next week. |
This issue can be closed? as #855 finished. @nicolastakashi @open-telemetry/helm-maintainers |
We had a PR open #833 to add ebpf collection to opentelemetry-collector chart
Let's discuss it.
There seems to be three components suggested:
I think we mostly we want this as a separate helm chart. I'm not sure how everything relates and works. Should everything be a single chart? How do we propose new charts and who should maintain it?
cc: @TylerHelmuth @dmitryax @atoulme @nicolastakashi
The text was updated successfully, but these errors were encountered: