Move to io.opentelemetry.semconv:opentelemetry-semconv #1055
Conversation
There was a problem hiding this comment.
Thank you very much for your contribution.
I'm sorry but I propose a slightly different path forward:
I propose to decouple and solve later the question of adopting the new convention and to implement it aligning with the OTel Java Auto Instr that added a config flag OTEL_SEMCONV_STABILITY_OPT_IN / otel.semconv-stability.opt-in.
I created a PR narrowed down to the change of lib:
| @@ -86,8 +86,8 @@ public void enrichSpan(SpanBuilder spanBuilder, ExecutionEvent executionEvent) { | |||
| spanBuilder.setAttribute( | |||
| MavenOtelSemanticAttributes.MAVEN_BUILD_CONTAINER_REGISTRY_URL, | |||
| "https://" + registryHostname); | |||
| spanBuilder.setAttribute(SemanticAttributes.HTTP_URL, "https://" + registryHostname); | |||
| spanBuilder.setAttribute(SemanticAttributes.HTTP_METHOD, "POST"); | |||
| spanBuilder.setAttribute(SemanticAttributes.URL_FULL, "https://" + registryHostname); | |||
There was a problem hiding this comment.
I propose to decouple and solve later the question of adopting the new convention and to implement it aligning with the OTel Java Auto Instr that added a config flag OTEL_SEMCONV_STABILITY_OPT_IN / otel.semconv-stability.opt-in.
I created a PR narrowed down to the change of lib:
|
FYI I initiated a PR to add optional support for the stable HTTP Semantic Conventions on: |
|
Closing in favor of #1299 |
Description:
io.opentelemetry:opentelemetry-semconv was moved to io.opentelemetry.semconv:opentelemetry-semconv and the former is now deprecated as per open-telemetry/opentelemetry-java#5786.
Existing Issue(s):
#1044
Testing:
Unittest execution
Documentation:
Outstanding items: