jfr-connection: jfr-connection: wrong parameter sent to JFR DiagnosticCommand #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanbisutti
reviewed
Oct 10, 2024
jeanbisutti
reviewed
Oct 15, 2024
.../java/io/opentelemetry/contrib/jfr/connection/FlightRecorderDiagnosticCommandConnection.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/contrib/jfr/connection/FlightRecorderDiagnosticCommandConnection.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/contrib/jfr/connection/FlightRecorderDiagnosticCommandConnection.java
Show resolved
Hide resolved
jeanbisutti
approved these changes
Oct 16, 2024
trask
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Change parameter used with JFR DiagnosticCommand from "name" to "recording" since it is the recording id that jfr-connection uses to identify JFR recordings.
Existing Issue(s):
1491
Testing:
Functionality already covered by existing tests
Documentation:
No documentation changes required.
Outstanding items:
None.