Breakout ResourceHolder from AwsXrayRemoteSamplerProvider #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
CLA signed, but can't get the workflow to update. Will just close and re-open. Update: that worked. |
trask
reviewed
Apr 2, 2023
aws-xray/src/main/java/io/opentelemetry/contrib/awsxray/AwsXrayRemoteSamplerProvider.java
Show resolved
Hide resolved
ResourceHolder provides generic utility for other components in the awsxray package, and could be more broadly used. In this commit, we are breaking out the ResourceHolder inner class to it's own class, and exposing the functionality of getResource, so that other classes can rely on it. Further, we are deprecating the original ResourceHolder, which we believe was not originally intended to be widely visible/accessible. Related issue: open-telemetry#789
trask
approved these changes
Apr 3, 2023
willarmiros
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
ResourceHolder provides generic utility for other components in the awsxray package, and could be more broadly used. In this commit, we are breaking out the ResourceHolder inner class to it's own class, and exposing the functionality of getResource, so that other classes can rely on it.
Specifically, we are working on new components to meet the needs of #789, which will require the use of this ResourceHolder. Opening up ResourceHolder seems to us to be the best path forward.
Existing Issue(s):
Tangentially related: #789
Testing:
./gradlew clean assemblesucceedsDocumentation:
Unclear if any documentation is required here, can help contribute this as needed. ResourceHolder is a new independent component that can be used to retrieve the Resource from autoconfiguration.
Outstanding items:
None